Fix PortAnaRecord crash on duplicate "datetime" level (#1909)#2216
Open
genisis0x wants to merge 1 commit into
Open
Fix PortAnaRecord crash on duplicate "datetime" level (#1909)#2216genisis0x wants to merge 1 commit into
genisis0x wants to merge 1 commit into
Conversation
When the prediction DataFrame's MultiIndex carries two levels both named
"datetime" (which can happen with some handler/processor chains), pandas
raises "datetime occurs multiple times" on the name-based lookup. Resolve
the level positionally instead via index.names.index("datetime").
Same fix applied to MultiPassPortAnaRecord.random_init.
Fixes microsoft#1909
Author
|
@microsoft-github-policy-service agree |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PortAnaRecord._generateandMultiPassPortAnaRecord.random_initresolved the prediction DataFrame'sdatetimelevel by name viaindex.get_level_values(\"datetime\").datetime. In that case pandas raisesValueError: 'datetime' occurs multiple times, which is the crash in datetime occurs multiple times #1909.dt_level = index.names.index(\"datetime\")thenindex.get_level_values(dt_level). That returns the firstdatetimelevel deterministically and survives duplicate names.Test plan
tests/misc/test_record_temp_duplicate_datetime.pybuilds a MultiIndex with duplicatedatetimenames and asserts:ValueError(precondition)datetimeindexes)Fixes #1909