Skip to content

fix: handler_mod func don't work when dealing None end date #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunsetWolf merged 2 commits into from
Dec 27, 2025
Merged

fix: handler_mod func don't work when dealing None end date #2068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c1f546
[fix] handler_mod func don't work when dealing None end date
lingbai-kong Dec 24, 2025
d16bd6c
refactor: avoid deep access by extracting handler_kwargs and using ge…
SunsetWolf Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions qlib/workflow/task/gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,15 +106,13 @@ def handler_mod(task: dict, rolling_gen):
rg (RollingGen): an instance of RollingGen
"""
try:
interval = rolling_gen.ta.cal_interval(
task["dataset"]["kwargs"]["handler"]["kwargs"]["end_time"],
task["dataset"]["kwargs"]["segments"][rolling_gen.test_key][1],
)
# if end_time < the end of test_segments, then change end_time to allow load more data
if interval < 0:
task["dataset"]["kwargs"]["handler"]["kwargs"]["end_time"] = copy.deepcopy(
task["dataset"]["kwargs"]["segments"][rolling_gen.test_key][1]
)
handler_kwargs = task["dataset"]["kwargs"]["handler"]["kwargs"]
handler_end_time = handler_kwargs.get("end_time")
test_seg_end_time = task["dataset"]["kwargs"]["segments"][rolling_gen.test_key][1]
# if the end of test_segments is None (open-ended segment, i.e., "until now") or end_time < the end of test_segments,
# then change end_time to allow load more data
if test_seg_end_time is None or rolling_gen.ta.cal_interval(handler_end_time, test_seg_end_time) < 0:
handler_kwargs["end_time"] = copy.deepcopy(test_seg_end_time)
except KeyError:
# Maybe dataset do not have handler, then do nothing.
pass
Expand Down
Loading