fix: filter out WSL Windows drive mount paths in conda locator (Fixes #369)#370
Merged
karthiknadig merged 2 commits intomainfrom Mar 5, 2026
Merged
fix: filter out WSL Windows drive mount paths in conda locator (Fixes #369)#370karthiknadig merged 2 commits intomainfrom
karthiknadig merged 2 commits intomainfrom
Conversation
Test Coverage Report (Linux)
Coverage increased! Great work! |
Performance Report (Linux) ➖
Legend
|
Performance Report (Windows) ✅
Legend
|
Test Coverage Report (Windows)
Coverage unchanged. |
Performance Report (macOS)
Legend
|
eleanorjboyd
approved these changes
Mar 5, 2026
3 tasks
Veykril
pushed a commit
to zed-industries/zed
that referenced
this pull request
Mar 18, 2026
This PR updates the pet dependency to incorporate performance improvements from upstream. Related Upstream Changes: - Issue: microsoft/python-environment-tools#369 - PR: microsoft/python-environment-tools#370 Updating pet reduces toolchain discovery time in WSL environments, specifically when Conda is installed on the host Windows system. In my testing, the time from clicking the toolchain button to the list appearing was reduced by approximately 2 seconds. While this is a notable improvement, discovery in WSL remains slightly slower than in native development or remote Linux environments, where toolchains are typically loaded near-instantaneously. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing (no need) - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Improved python toolchain discovery under WSL environment
AmaanBilwar
pushed a commit
to AmaanBilwar/zed
that referenced
this pull request
Mar 20, 2026
…stries#51749) This PR updates the pet dependency to incorporate performance improvements from upstream. Related Upstream Changes: - Issue: microsoft/python-environment-tools#369 - PR: microsoft/python-environment-tools#370 Updating pet reduces toolchain discovery time in WSL environments, specifically when Conda is installed on the host Windows system. In my testing, the time from clicking the toolchain button to the list appearing was reduced by approximately 2 seconds. While this is a notable improvement, discovery in WSL remains slightly slower than in native development or remote Linux environments, where toolchains are typically loaded near-instantaneously. Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing (no need) - [x] Done a self-review taking into account security and performance aspects - [x] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - Improved python toolchain discovery under WSL environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On WSL2,
~/.conda/environments.txtis shared with the Windows host and contains paths like/mnt/d/Tools/Anaconda/envs/...that point to Windows PE executables unusable from Linux. PET would try to find a conda manager for each, fail, and log ERROR for every environment — causing log spam and ~6s overhead.Changes:
is_windows_drive_mount()helper (Unix-only) to detect/mnt/<drive>/...pathsis_wsl()helper using/proc/versionWSL signature detection with result cachingget_conda_environment_paths()before expensive scanningFixes #369