extracting locales for default string arguments on blocks#11406
Merged
Conversation
jwunderl
changed the title
srietkerk
reviewed
Jun 12, 2026
|
|
||
| export function parameterDefaultToLocalizationString(defaultValue: string, type?: string) { | ||
| if (!defaultValue) return undefined; | ||
| if (type === "string" && defaultValue.charAt(0) !== "\"") return defaultValue; |
Contributor
There was a problem hiding this comment.
Should this be
Suggested change
| if (type === "string" && defaultValue.charAt(0) !== "\"") return defaultValue; | |
| if (type === "string" && defaultValue.charAt(0) === "\"") return defaultValue; |
Member
Author
There was a problem hiding this comment.
the is the 'bail out if the default value is not explicitly a string' check, e.g. if this is set to a blockid for a block that returns a string
Contributor
There was a problem hiding this comment.
Ah, gotcha, thanks for the clarification!
srietkerk
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix microsoft/pxt-microbit#6687
extracting out .defl= and e.g. defaults we use for parameter defaults (it looks like still some not checked in for e.g. unit conversions and color helpers from build), but these are the ones it'll add into microbit / will check in updated locales files after getting this in to update baseline:
