Bump pxt 12.x and some other changes#1052
Bump pxt 12.x and some other changes#1052THEb0nny wants to merge 102 commits intomicrosoft:masterfrom
Conversation
|
Fixed all fields field_motors, field_ports, field_brickbuttons, field_music except field_color. When choosing a color, the color does not change. There is no error in the console. |
Replacing ports with images. field ports has been removed. Almost completely repeats the functionality.
|
Replacing field ports to images. field ports has been removed. Almost completely repeats the functionality. All sensor blocks that used field_ports had to register this. I don’t know how it could have been done differently without repeating these lines. Accidentally added field_colors changes to this commit. He's not ready. There are no errors, but the color selection does not work. |
Where did turnRatio come from?
The last change to field_colour removed the addition of className. It’s not clear for what reason, but I’m adding it myself now.
The new version of FieldColorNumber does not apply applyColour() inside the doValueUpdate_() method. Secondly, the applyColour() method was redesigned in the new version so that it no longer worked with this enum code.
|
The colorenum field has been fixed. |
BlocklyDropDownContent legoColorPicker color none crossed out style
|
It turned out that the dropdown field-color was slightly broken. I also changed it so that the no-color option would display a red strikethrough. |
|
I also made a transparent pattern for the color none in the dropdown. 
|
For color none, I set a transparent pattern instead of a color for the block with colorEnumPicker.
|
I also made a transparent pattern for color none in colorEnumPicker. 
|
|
@abchatra will there be an opportunity to consider changes for the merger? |
|
@riknoll will there be an opportunity to do a review? |
|
@THEb0nny we are no longer updating the EV3 editor. at this point, it can be considered retired. we have no plans currently to remove the hosted website, but unfortunately we don't have the bandwidth to get this repo to the point where it can be deployed again. as such, i'm going to close this PR because we cannot release it. however, if you wish to continue development on your own fork, please see the documentation here for a command in the PXT cli that can be used to produce a static version of the website that you can host with any static webserver (or packaged as an electron app): https://makecode.com/cli/staticpkg please let me know if you have any problems getting setup with statickpkg |
|
@riknoll @abchatra this sounds very sad. I don't understand. Lego EV3 is still widely used in education... |
|
unfortunately, it does require resources on our side to keep our build/release pipelines running, review PRs, test for quality, etc. as i stated, we have no plans at this time to remove the hosted site. as it stands now the only updates we will consider are those that are necessary to stay compliant with security and privacy obligations. if you want to release your changes, i recommend hosting your own site or releasing a version on github pages using the staticpkg command. |
|
@riknoll If I publish a static site, I don't understand how support for string resources running through CrowdIn will work. I also don't understand how sharing a project via a link will work. |
|
staticpkg will package all of the existing strings from crowdin, but you won't be able to publish any new ones. i guess if you need updated versions of the common editor strings then you could fetch them by cloning a supported target (like micro:bit) and downloading the translations using the CLI. i don't remember the syntax, but there is a command in the PXT CLI that will fetch all the built translations for a given target. you are correct that sharing will not work with a static site though |
|
@riknoll what else might a backend be needed for, besides supporting the project sharing feature? Is it even possible to implement this feature on your own server? |
|
it's certainly possible to implement your own sharing API, the API is pretty simple. you might need to modify some settings to make it hit your endpoint, however. the main other feature our backend provides is C++ compilation, which i'm guessing is not that big a deal for your purposes since i don't think too many people are creating EV3 projects/extensions with C++ in them |
|
@riknoll I understand that the functions from GitHub don't work either? |
|
@riknoll How do I use Github Actions to build pxt staticpkg correctly? The build succeeds, but the page returns 404 errors for all files. The URLs listed are /docs/static/..., but they should be /pxt-ev3/docs/static/ Example |
|
@riknoll I don't understand why I didn't move the gallery text to the main page. And why are the links identical to the same materials, even though the action scrolls and changes the links. |
|
@riknoll I don't understand, why does the editor in the local version access makecode.com to upload a resource to the galleries on the main page? The editor deployed on the server does the same thing. It's the same as the editor accessing the translation. |
After switching to pxt-core v10, fieldmotors break.
Related to this.
I understand that these changes should be considered after this
#1048
microsoft/pxt-microbit#5496
microsoft/pxt#9865