Compatibility with Unity & Android#333
Open
AuMilliat wants to merge 31 commits intomicrosoft:masterfrom
Open
Conversation
Unregestering from parentPipeline.
Author
|
caa6e1b 10df5c0 Merge differents modifications of Pipeline (ie CreateSynchedPipeline, switch some attributes from private to internal...) and add the RemotePipelineClockExporter/Importer components that allow to synch remote \psi applications from a dataset. (Our use case is to replay the datasets in our XR platforms). |
Author
|
Still 2 tests failing on my side:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed modifications:
Adding Microsoft.Psi.InteropAndroid, that is a reduction of Microsoft.Psi.Interop for TCPSource/Writer with a modification of dynamic to template (crash with refecerence exception on Quest).
Microsoft.Psi project modifications:
PsiStore path need to be changed for Android and check the permission to write at application level.
KnowSerializer instance writeable to allow the addition of ‘serializer’ and public to application level.
Mutex downgrade code & Removing null check operator to be compatible with Mono & Android.
Some modifications are unnecessary (or not complete) as the first target was to use Emitters and Receivers (commit ID: 446a0fa).