fix: tolerate page errors without location#41302
Open
mturac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41169.
When a browser reports a page error without source location metadata, normalize it to an empty location before storing and dispatching the error. This keeps both
pageerrorandweberrorevents flowing instead of crashing the driver while preserving the existing event payload shape.The Firefox protocol type now reflects that
Page.uncaughtError.locationcan be omitted.Validation:
npm run buildnode packages/playwright-test/cli.js test --config=tests/library/playwright.config.ts browsercontext-events.spec.ts -g "weberror event should tolerate missing location"npm run tsc -- --pretty falsenpm run eslint -- packages/playwright-core/src/server/page.ts tests/library/browsercontext-events.spec.tsgit diff --check