Skip to content

fix: avoid waiting for inherited Edge stdio#41299

Open
mturac wants to merge 1 commit into
microsoft:mainfrom
mturac:fix/issue-41210-msedge-close
Open

fix: avoid waiting for inherited Edge stdio#41299
mturac wants to merge 1 commit into
microsoft:mainfrom
mturac:fix/issue-41210-msedge-close

Conversation

@mturac

@mturac mturac commented Jun 15, 2026

Copy link
Copy Markdown

Fixes #41210

Summary

  • add an internal process launcher option for browser processes whose helpers can inherit stdio and outlive the main process
  • use that path for msedge* channels so browser.close() can finish after the browser process exits
  • add regression coverage with a Node child that leaves an inherited-stdio grandchild running

Testing

  • npm run build
  • npm run ttest -- process-launcher.spec.ts
  • npm run tsc -- --pretty false
  • npx eslint packages/utils/processLauncher.ts packages/playwright-core/src/server/browserType.ts tests/playwright-test/process-launcher.spec.ts
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: browser.close() with channel "msedge" can block ~20s while EdgeUpdater holds the stdio pipe

1 participant