Skip to content

fix(trace): waitForLoadState title #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 2 commits into from
Sep 8, 2025
Merged

fix(trace): waitForLoadState title #1840

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c2eb4
fix(trace): waitForLoadState title
Skn0tt Sep 4, 2025
4743a3f
rename
Skn0tt Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,10 +1357,13 @@ public JSHandle waitForFunction(String pageFunction, Object arg, WaitForFunction
}

@Override
public void waitForLoadState(LoadState state, WaitForLoadStateOptions options) {
withWaitLogging("Page.waitForLoadState", logger -> {
mainFrame.waitForLoadStateImpl(state, convertType(options, Frame.WaitForLoadStateOptions.class), logger);
return null;
public void waitForLoadState(LoadState _state, WaitForLoadStateOptions options) {
final LoadState state = _state == null ? LoadState.LOAD : _state;
Copy link
Copy Markdown
Member

@yury-s yury-s Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we don't use underscore in the var names.

withTitle("Wait for load state \"" + state.toString().toLowerCase() + "\"", () -> {
withWaitLogging("Page.waitForLoadState", logger -> {
mainFrame.waitForLoadStateImpl(state, convertType(options, Frame.WaitForLoadStateOptions.class), logger);
return null;
});
});
}

Expand Down
20 changes: 20 additions & 0 deletions playwright/src/test/java/com/microsoft/playwright/TestTracing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,4 +359,24 @@ public void shouldNotRecordNetworkActions(@TempDir Path tempDir) throws Exceptio
});
});
}

@Test
public void shouldShowWaitForLoadState(@TempDir Path tempDir) throws Exception {
// https://github.com/microsoft/playwright/issues/37297

context.tracing().start(new Tracing.StartOptions());

page.navigate(server.EMPTY_PAGE);
page.waitForLoadState();

Path traceFile1 = tempDir.resolve("trace1.zip");
context.tracing().stop(new Tracing.StopOptions().setPath(traceFile1));

TraceViewerPage.showTraceViewer(this.browserType, traceFile1, traceViewer -> {
assertThat(traceViewer.actionTitles()).hasText(new Pattern[] {
Pattern.compile("Navigate to \"/empty.html\""),
Pattern.compile("Wait for load state \"load\""),
});
});
}
}
Loading