fix(build): suppress nullable warnings on JsonElement? .Value access#3316
Merged
Conversation
Newer Roslyn (in .NET SDK 10 used by the noble Docker image, and the 8.0.421 SDK in CI) now flags CS8629 on the (await SendMessageToServerAsync(...)).Value.GetProperty(...) pattern. Add the null-forgiving operator since the server response is always non-null in the success path.
Skn0tt
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(await SendMessageToServerAsync(...)).Value.GetProperty(...)pattern..Valueso the new Roslyn null-flow analysis is satisfied; runtime behavior is unchanged since these responses are always non-null in the success path.Fixes the failing checks on 9c36b8d.