fix: update deprecated Playwright API usage in running-code docs#277
Closed
willcoliveira wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: update deprecated Playwright API usage in running-code docs#277willcoliveira wants to merge 1 commit intomicrosoft:mainfrom
willcoliveira wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
yury-s
approved these changes
Feb 24, 2026
| playwright-cli run-code "async page => { | ||
| try { | ||
| await page.click('.maybe-missing', { timeout: 1000 }); | ||
| await page.locator('.maybe-missing').click({ timeout: 1000 }); |
Member
There was a problem hiding this comment.
Would be even better to instruct it to use role locators
yury-s
reviewed
Feb 24, 2026
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
This file is rolled from upstream, all updates should go to https://github.com/microsoft/playwright/blob/main/packages/playwright/src/skill/references/running-code.md
Member
|
Feel free to open a PR in the main repo. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page.click(),page.fill(),page.waitForSelector()with modernpage.locator()equivalents inrunning-code.mdPromise.allrace condition anti-pattern in file download exampleTest plan
running-code.mduse current Playwright APIspage.click,page.fill,page.waitForSelector)