This repository was archived by the owner on Nov 20, 2024. It is now read-only.
fix crash when target package doesn't have a key and sort package keys before output#4
Open
nickpalmer wants to merge 2 commits intomicrosoft:mainfrom
Open
fix crash when target package doesn't have a key and sort package keys before output#4nickpalmer wants to merge 2 commits intomicrosoft:mainfrom
nickpalmer wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Package managers ususally sort package keys alphabetically. If you newly inherit then you may get a bunch of additions which will then be unalphabatized, leading to a messy diff if a new package is added with the package manager.
|
|
|
same issue, plz merge |
|
Hi @nick, I am curious to know how you got this project working in the first place. would you have a test project handy? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a great tool. Thanks for putting it together.
I stumbled on two issues while adding it to our system.
I added an inherit which had a devDependencies block to a package that didn't already have devDependencies block which triggered a crash. The first commit fixes that crash.
I also noted that when adding a new inherit the packages were no longer sorted. Adding a package with a package manager like yarn or npm would cause many lines to move because package managers sort these keys before output. Thus I have added sorting for these keys before outputting them to match package manager behavior when potentially adding a new inherit to a package.