-
Notifications
You must be signed in to change notification settings - Fork 18
ci(nightly): resolve tree-borrows termination and improve nightly stability #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgalkin
wants to merge
27
commits into
main
Choose a base branch
from
u/sgalkin/nightly
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−3
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ba6531f
chore(actions): reduce number of Miri seeds per nightly run
b9e3936
extend timeout for miri steps
7f81445
fixup! extend timeout for miri steps
21bf7f9
debug(miri): add OOM diagnostics to miri-tree-borrows job
c250b01
debug(miri): add cgroup and resource limit diagnostics
a3f294b
debug(miri): disable other jobs, focus on tree-borrows only
455f49a
debug(miri): use ubuntu-latest-8-cores runner (32 GB RAM)
f639431
debug(miri): isolate heavy crates to per-test Miri processes
8196c06
debug(miri): revert to ubuntu-latest runner
69b457d
debug(miri): fix isolation to use --lib only for per-test runs
d4feeb5
debug(miri): try ubuntu-latest-8-cores runner
55e7b60
debug(miri): skip OOM-inducing u16::MAX tests in tree-borrows
d2b9624
fix(miri): add configurable skip-tests input for tree-borrows job
d6b66bd
fix(miri): only skip the confirmed OOM test
d80a2a8
fix(miri): use full module path for skipped test
545cf65
fix(miri): use skip file for tree-borrows test exclusions
0a5bd32
fix(miri): skip try_alloc_uninit_slice_arc OOM test in tree-borrows
371261a
fix(miri): add suppression file for tree-borrows OOM tests
e15f3f0
docs(miri): document suppression file in nightly workflow
d3071b8
Merge branch 'sgalkin-microsoft/debug-miri-tree-borrows-oom' into u/s…
329d83f
docs(miri): document daily seed rotation in race-coverage job
5780666
Potential fix for pull request finding
sgalkin 594dced
fix(miri): address PR review feedback
1d15080
Merge branch 'main' into u/sgalkin/nightly
sgalkin 73d03a7
Potential fix for pull request finding
sgalkin a873ce2
Potential fix for pull request finding
sgalkin 9ce2e03
Merge branch 'main' into u/sgalkin/nightly
sgalkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Miri tree-borrows test suppression list | ||
| # | ||
| # Tests listed here are skipped during the `miri-tree-borrows` nightly | ||
| # CI job. Each entry is passed as a `--skip` argument to `cargo miri | ||
| # test` (substring match). Use fully-qualified test paths to avoid | ||
| # accidentally suppressing unrelated tests. | ||
| # | ||
| # These tests are functionally correct but exceed the 16 GB memory | ||
| # limit of the GitHub Actions runner due to Miri's tree-borrows | ||
| # per-byte provenance tracking. They pass locally on machines with | ||
| # 32+ GB RAM. | ||
| # | ||
| # To run all tests (e.g. on a larger runner), delete or empty this file. | ||
| # | ||
| # arena::tests::alloc_slice_local_with_or_panic_at_max_normal_uses_fast_path | ||
| # Although the allocation itself is only 4 KiB (512 u64s), the | ||
| # arena's bump-fit / drop-entry / protective-hold path involves | ||
| # many pointer reborrows into the 64 KiB pre-allocated chunk. | ||
| # Under tree-borrows the per-byte provenance tracking exceeds | ||
| # the 16 GB runner memory limit. | ||
| arena::tests::alloc_slice_local_with_or_panic_at_max_normal_uses_fast_path | ||
|
|
||
| # arena::tests::try_alloc_uninit_slice_arc_at_max_normal_uses_fast_path | ||
| # Shared-chunk sibling of the above. The Arc-based allocation path | ||
| # with atomic refcounting creates additional provenance nodes under | ||
| # tree-borrows, also exceeding 16 GB. | ||
| arena::tests::try_alloc_uninit_slice_arc_at_max_normal_uses_fast_path |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.