Skip to content

fix: re-release dependents of data_privacy 0.12 breaking change so they are compatible with latest data_privacy#472

Closed
Vaiz wants to merge 10 commits into
mainfrom
u/vaiz/2026/06/04/dataprivacycoredeps
Closed

fix: re-release dependents of data_privacy 0.12 breaking change so they are compatible with latest data_privacy#472
Vaiz wants to merge 10 commits into
mainfrom
u/vaiz/2026/06/04/dataprivacycoredeps

Conversation

@Vaiz
Copy link
Copy Markdown
Contributor

@Vaiz Vaiz commented Jun 4, 2026

interesting detail, templated_uri uses data_privacy::Sensitive which was not moved to data_privacy_core. As a result, breaking changes in data_privacy crate cascade through all depended crates. Maybe we should move Sensitive to core as well

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (4b0c91b) to head (54fcd33).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         319      319           
  Lines       24676    24676           
=======================================
  Hits        24676    24676           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vaiz Vaiz marked this pull request as ready for review June 4, 2026 12:29
Copilot AI review requested due to automatic review settings June 4, 2026 12:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the workspace to use data_privacy v0.12.0 and bumps the versions of downstream crates that depend on it, refreshing their generated READMEs and changelogs accordingly.

Changes:

  • Bump data_privacy to 0.12.0 and propagate version bumps to templated_uri, http_extensions, seatbelt_http, and fetch_hyper.
  • Refresh crate READMEs (docs.rs links / cargo-doc2readme dependency metadata) to reflect the new crate versions.
  • Update Cargo workspace dependency versions and Cargo.lock to match the new crate versions (with one mismatch currently).

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Cargo.toml Updates workspace dependency versions (notably includes a fetch_hyper version mismatch to fix).
Cargo.lock Updates resolved versions for the bumped workspace crates.
crates/templated_uri/Cargo.toml Bumps templated_uri crate version to 0.3.0.
crates/templated_uri/CHANGELOG.md Adds a 0.3.0 entry documenting the data_privacy bump as breaking.
crates/templated_uri/README.md Refreshes generated docs.rs links/metadata for 0.3.0.
crates/http_extensions/Cargo.toml Bumps http_extensions crate version to 0.5.0.
crates/http_extensions/CHANGELOG.md Adds a 0.5.0 entry for the data_privacy bump.
crates/http_extensions/README.md Refreshes generated docs.rs links/metadata for 0.5.0.
crates/seatbelt_http/Cargo.toml Bumps seatbelt_http crate version to 0.3.0.
crates/seatbelt_http/CHANGELOG.md Adds a 0.3.0 entry for data_privacy + http_extensions bumps.
crates/seatbelt_http/README.md Refreshes generated docs.rs links/metadata for 0.3.0.
crates/fetch_hyper/Cargo.toml Bumps fetch_hyper crate version to 0.3.0.
crates/fetch_hyper/CHANGELOG.md Adds a new release entry, but needs version alignment and conflict-marker cleanup.
crates/fetch_hyper/README.md Refreshes generated docs.rs links/metadata for 0.3.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Cargo.toml Outdated
Comment thread crates/fetch_hyper/CHANGELOG.md Outdated
Comment thread crates/fetch_hyper/CHANGELOG.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 4, 2026 12:41
Vaiz and others added 2 commits June 4, 2026 14:41
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Comment thread crates/fetch_hyper/CHANGELOG.md Outdated
Comment thread crates/seatbelt_http/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@sandersaares sandersaares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title says "bump data_privacy" but the content does not actually change version of data_privacy, instead changing version of other crates. What is happening here?

@sandersaares
Copy link
Copy Markdown
Member

Okay I am starting to get the picture - there was data_privacy 0.12 released but for some reason the dependents were not released. Why not? Ah, because #427 did not include them - it seems to be manually incremented version number, not via the script that cares for the dependency tree. I associate this with your question "what is the right way to release GitHub packages" in chat yesterday - this was just human error in not using the script.

@sandersaares sandersaares changed the title chore: bump data_privacy to 0.12 fix: re-release dependencies of data_privacy 0.12 breaking change so they are compatible with latest data_privacy Jun 5, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 5, 2026 06:23
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Vaiz
Copy link
Copy Markdown
Contributor Author

Vaiz commented Jun 5, 2026

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.

Comment thread crates/http_extensions/CHANGELOG.md
@sandersaares sandersaares changed the title fix: re-release dependencies of data_privacy 0.12 breaking change so they are compatible with latest data_privacy fix: re-release dependents of data_privacy 0.12 breaking change so they are compatible with latest data_privacy Jun 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 5, 2026

@copilot resolve the merge conflicts in this pull request

Resolved by merging origin/main into this branch and fixing all conflicts in commit 7ef8a5b.

Copilot finished work on behalf of Vaiz June 5, 2026 06:36
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 5, 2026 06:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Comment thread crates/http_extensions/CHANGELOG.md
@ralfbiedert
Copy link
Copy Markdown
Collaborator

Hm, just had a look and I even think I originally wrote the to_string() -> Sensitive<> pattern. The semantics of Sensitive changed a bit over time, originally this was meant to be an internal type only, but it also made sense to reach for it when revealing stringy information. I suppose we could move it to core, but then data_privacy ends up being a redactors crate + re-exports.

@Vaiz
Copy link
Copy Markdown
Contributor Author

Vaiz commented Jun 5, 2026

superseded by #477

@Vaiz Vaiz closed this Jun 5, 2026
@Vaiz Vaiz deleted the u/vaiz/2026/06/04/dataprivacycoredeps branch June 5, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants