Make microsoft-agents-hosting-core and microsoft-agents-activity optional dependencies#117
Open
rads-1996 wants to merge 15 commits intomicrosoft:mainfrom
Open
Make microsoft-agents-hosting-core and microsoft-agents-activity optional dependencies#117rads-1996 wants to merge 15 commits intomicrosoft:mainfrom
microsoft-agents-hosting-core and microsoft-agents-activity optional dependencies#117rads-1996 wants to merge 15 commits intomicrosoft:mainfrom
Conversation
…onal dependencies
rads-1996
requested review from
JacksonWeber,
MSNev,
hectorhdzg,
jeremydvoss and
lzchen
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR makes the hosting-related Microsoft Agents packages optional by moving them behind a new hosting extra and adding import-time fallback handling in hosting modules.
Changes:
- Moved
microsoft-agents-activityandmicrosoft-agents-hosting-corefrom core dependencies into a new optionalhostingextra inpyproject.toml. - Wrapped imports of hosting-specific Microsoft Agents symbols in
try/except ImportErrorblocks across hosting modules and added a shared install-hint message. - Updated migration documentation to explain the new optional dependency model and the
hostingextra.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
src/microsoft/opentelemetry/a365/hosting/token_cache_helpers/agent_token_cache.py |
Makes hosting-core imports optional and logs an install hint on missing dependency. |
src/microsoft/opentelemetry/a365/hosting/scope_helpers/utils.py |
Makes Activity import optional and logs an install hint. |
src/microsoft/opentelemetry/a365/hosting/scope_helpers/populate_baggage.py |
Makes TurnContext import optional and logs an install hint. |
src/microsoft/opentelemetry/a365/hosting/middleware/output_logging_middleware.py |
Makes activity/turn-context imports optional and logs an install hint. |
src/microsoft/opentelemetry/a365/hosting/middleware/observability_hosting_manager.py |
Makes MiddlewareSet import optional and logs an install hint. |
src/microsoft/opentelemetry/a365/hosting/middleware/baggage_middleware.py |
Makes activity/turn-context imports optional and logs an install hint. |
src/microsoft/opentelemetry/a365/constants.py |
Adds a shared install-hint string for missing hosting dependencies. |
pyproject.toml |
Moves hosting packages into a new optional dependency group. |
MIGRATION_A365.md |
Documents the new hosting extra and optional dependency behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - #76