Conversation
Signed-off-by: Xavier Dupré <xadupre@microsoft.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 70.51% 70.50% -0.01%
==========================================
Files 228 228
Lines 27214 27114 -100
Branches 2737 2726 -11
==========================================
- Hits 19189 19116 -73
+ Misses 7090 7065 -25
+ Partials 935 933 -2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Member
Author
|
The rounding for float16 is puzzling. |
Contributor
|
Looks like it's not ready yet? |
justinchuby
reviewed
Feb 10, 2026
justinchuby
reviewed
Feb 10, 2026
titaiwangms
reviewed
Feb 10, 2026
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an ONNXScript converter for aten::histc to unblock export of models that use torch.histc (Fixes #2794), and wires it into the torch-lib op test matrix with new e2e coverage.
Changes:
- Implement
aten::histcconverter inonnxscript/function_libs/torch_lib/ops/core.py. - Register
histcin the torch-lib op test data with targeted skips. - Add e2e export + reference-check tests for
torch.histc(float; float16 currently skipped due to upstream issue).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/function_libs/torch_lib/ops_test_data.py | Adds histc to the op list with skips for min==max and float16. |
| tests/function_libs/torch_lib/e2e_ops_tests.py | Adds e2e tests for exporting and numerically validating torch.histc. |
| onnxscript/function_libs/torch_lib/ops/core.py | Introduces a trace-only ONNX lowering for aten::histc. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
justinchuby
reviewed
Feb 11, 2026
justinchuby
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2794.