Surface portable UI capability facts via --probe#490
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates MXC’s Windows probe output and the TypeScript SDK’s platform support surface to report portable UI restriction capability facts (uiCapabilities) instead of Windows-specific UI-limit details, enabling callers to reason about UI restrictions in a platform-neutral way.
Changes:
- Rust: emit
uiCapabilitiesfromwxc-exec --probebased on the OS build’s supported UI restriction primitives. - SDK: add
PlatformSupport.uiCapabilities/UiCapabilitySupport, validate probe output at runtime, and export the new types publicly. - Tests/docs: add Rust + SDK unit tests for input-injection / input-method capability cases; update SDK README and changelog.
Show a summary per file
| File | Description |
|---|---|
| src/backends/appcontainer/common/src/probe.rs | Adds ui_capabilities to probe JSON output and serialization coverage tests. |
| src/backends/appcontainer/common/src/job_object.rs | Introduces supported_ui_restrictions() to expose platform-agnostic UI restriction support derived from supported UI-limit flags. |
| sdk/tests/unit/platform.test.ts | Adds unit tests ensuring getPlatformSupport() correctly surfaces/omits uiCapabilities based on probe payload validity. |
| sdk/src/types.ts | Defines UiCapabilitySupport and adds optional uiCapabilities to PlatformSupport. |
| sdk/src/platform.ts | Adds runtime validation for uiCapabilities and plumbs probe facts into PlatformSupport. |
| sdk/src/index.ts | Exports UiCapabilitySupport from the public SDK entrypoint. |
| sdk/README.md | Documents uiCapabilities as part of getPlatformSupport() behavior and lists the new capability type. |
| sdk/CHANGELOG.md | Notes the new uiCapabilities reporting under the Unreleased section. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 0
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bbonaby
reviewed
Jun 3, 2026
1e5eecf to
0356d87
Compare
This PR changes the platform probe and SDK support API to expose portable UI capability facts instead of Windows-specific UI-limit details. Details * Emit a uiCapabilities object from the Rust probe that maps native Windows UI-limit support into platform-neutral restriction capabilities. * Expose PlatformSupport.uiCapabilities and UiCapabilitySupport in the SDK, with TypeScript validation for probe output. * Cover missing input-injection and input-method support cases in Rust and SDK tests. Tests * npm test in sdk/ passed. * npm run build in sdk/ passed. * cargo fmt --all -- --check in src/ passed. * cargo test -p appcontainer_common probe in src/ passed. * cargo test -p appcontainer_common supported in src/ passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0356d87 to
9d82a65
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). #Resolved |
See additional documentation. |
jsidewhite
reviewed
Jun 4, 2026
jsidewhite
reviewed
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the platform probe and SDK support API to expose portable UI
capability facts instead of Windows-specific UI-limit details.
Details
UI-limit support into platform-neutral restriction capabilities.
TypeScript validation for probe output.
tests.
Tests
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Microsoft Reviewers: Open in CodeFlow