Fix missing UefiLib dependency in MfciPolicyParsingUnitTestApp#887
Merged
makubacki merged 1 commit intoMay 12, 2026
Merged
Conversation
Contributor
⏩ QEMU Validation SkippedThe PR was merged before validation completed. This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #887 +/- ##
=================================================
Coverage ? 34.00%
=================================================
Files ? 17
Lines ? 1876
Branches ? 528
=================================================
Hits ? 638
Misses ? 1225
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
May 11, 2026
makubacki
approved these changes
May 12, 2026
Member
|
@GiriMohanNaidu, for completeness, can you please identify what is used from |
makubacki
force-pushed
the
p/v-gimoha/UefiLib
branch
from
3831422 to
a149bb7
Compare
Member
Thanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the missing UefiLib library class dependency to MfciPolicyParsingUnitTestApp.inf. The module uses UefiLib APIs but did not declare the dependency in its [LibraryClasses] section, causing build failures when the library was not implicitly pulled in by the platform DSC.
The module uses AsciiPrint() from UefiLib but did not declare the dependency in its LibraryClasses section.
How This Was Tested
Built MfciPkg/UnitTests/MfciPolicyParsingUnitTest/MfciPolicyParsingUnitTestApp.inf and confirmed the build completes without missing library errors.
Integration Instructions
N/A — consumers of MfciPkg do not need any changes; this only affects the unit test app build.