AdvancedLoggerPkg/MmCoreArm: Initialize LoggerInfo if not already set by earlier firmware phase#886
Merged
Conversation
…D_LOGGER_INFO header in AdvancedLoggerGetLoggerInfo when no earlier firmware phase has done so Signed-off-by: Sureshkumar Ponnusamy <sponnusamy@microsoft.com>
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_plus/actions/runs/25602544396 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/202511 #886 +/- ##
================================================
Coverage ? 3.07%
================================================
Files ? 36
Lines ? 4266
Branches ? 73
================================================
Hits ? 131
Misses ? 4129
Partials ? 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sureshkumarpMSFT
changed the title
sureshkumarpMSFT
changed the title
os-d
reviewed
May 8, 2026
makubacki
reviewed
May 8, 2026
…rLib.c Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
…rLib.c Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>
…rLib.c Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Sureshkumar Ponnusamy <sponnusamy@microsoft.com>
Signed-off-by: Sureshkumar Ponnusamy <sponnusamy@microsoft.com>
os-d
approved these changes
May 8, 2026
apop5
approved these changes
May 8, 2026
makubacki
approved these changes
May 9, 2026
Signed-off-by: Sureshkumar Ponnusamy <sponnusamy@microsoft.com>
Signed-off-by: Sureshkumar Ponnusamy <sponnusamy@microsoft.com>
apop5
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the MmCoreArm instance of AdvancedLoggerLib, AdvancedLoggerGetLoggerInfo() previously assumed that an earlier firmware phase (e.g. BL31 prior to StandaloneMM) had already initialized the ADVANCED_LOGGER_INFO header at PcdAdvancedLoggerBase. On ARM boot flows where StandaloneMM is the first phase to touch this buffer, the signature check in subsequent logger calls fails and no log records are written.
This change adds a one-time, in-place initialization of the ADVANCED_LOGGER_INFO header inside AdvancedLoggerGetLoggerInfo() when the signature is not already valid:
How This Was Tested
Verified on an ARM platform where no pre-StandaloneMM entity initializes the AdvancedLogger buffer
Integration Instructions
N/A