debug changes 1#253
Draft
Flickdm wants to merge 3 commits into
Draft
Conversation
mu-automation
Bot
added
the
impact:non-functional
Enable AdvancedLogger-based debug output for the OneCryptoBinDxe module on AARCH64 by replacing BaseDebugLibNull with BaseDebugLibAdvancedLogger and configuring debug PCDs. - Add PcdsPatchableInModule.AARCH64 for PcdDebugPropertyMask - Add PcdsFixedAtBuild.AARCH64 for debug print error levels - Add AARCH64-specific OneCryptoPkg debug property/level PCDs - Switch OneCryptoBinDxe DebugLib to AdvancedLogger with required DebugPrintErrorLevelLib, AdvancedLoggerLib, and AssertLib library instances Signed-off-by: Doug Flick <dougflick@microsoft.com>
DebugPrint was passing a VA_LIST directly to OneCryptoDebugPrint which expects variadic arguments, not a VA_LIST. Format the message into a local buffer with AsciiVSPrint first, then pass the resulting string via %a to avoid variadic forwarding issues. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Only free the X509 certificate stack on failure when it was newly allocated by the function. Previously, a pre-existing stack passed by the caller would be incorrectly freed on error. Track allocation origin with a NewlyAllocated flag and add DEBUG logging for diagnostic visibility. Signed-off-by: Doug Flick <dougflick@microsoft.com>
Flickdm
force-pushed
the
draft/debug/aarc64
branch
from
31ccd36 to
e486241
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (63.64%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
<Include a description of the change and why this change was made.>
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>