Fix noopt builds#248
Draft
Flickdm wants to merge 2 commits into
Draft
Conversation
Only DEBUG and RELEASE crypto binaries are published, but the generated DSC and FDF include files used $(TARGET) directly. When building with TARGET=NOOPT, the DSC paths resolved to nonexistent .inf files and the FDF conditionals matched neither DEBUG nor RELEASE, excluding all crypto binaries. Introduce a CRYPTO_TARGET define that maps $(TARGET) to RELEASE when TARGET is RELEASE, and to DEBUG otherwise. Replace all $(TARGET) usage in generated .inf paths (DSC) and binary selection conditionals (FDF) with $(CRYPTO_TARGET). Signed-off-by: Doug Flick <dougflick@microsoft.com>
Regenerate all autogenerated DSC, FDF, and INF files using generate_cryptodriver.py to pick up the CRYPTO_TARGET changes. Signed-off-by: Doug Flick <dougflick@microsoft.com>
1 task
mu-automation
Bot
added
language:python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maps TARGET to DEBUG when the TARGET is not set to RELEASE
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
TODO
Integration Instructions
TODO