Skip to content

Revert the previous TPM table revert..#1798

Merged
kuqin12 merged 2 commits into
release/202511from
revert_revert
May 14, 2026
Merged

Revert the previous TPM table revert..#1798
kuqin12 merged 2 commits into
release/202511from
revert_revert

Conversation

@kuqin12
Copy link
Copy Markdown
Contributor

@kuqin12 kuqin12 commented May 14, 2026

Description

The TPM over FFA table revert was not necessary. Bringing back the bug fix to the mainline.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This is a one-to-one reversion.

Integration Instructions

N/A

kuqin12 added 2 commits May 14, 2026 11:24
…n ID

Current Tcg2AcpiFfa will populate the partition ID in byte order of big-
endian. This conflicts with the TCG ACPI Specification, which specifies
the byte-order to be little-endian.

This change corrects the byte order population process by replacing the
platform parameter byte array with MdePkg defined structure.

Signed-off-by: Kun Qin <kun.qin@microsoft.com>

This re-applies the commit a270773cce476ed0be9eb9b6370164d1d1fb0796.
… TPM2 table

Given the start method of FFA is only introduced in revision 5 of the TCG
ACPI specification. A TPM2 table with FFA start method and lower than 5
revision should not be allowed.

This change updates the checks for revision PCD and removed a few
conditions based on new revision 5 assumptions.

Signed-off-by: Kun Qin <kun.qin@microsoft.com>

This re-applies the commit f1fc41cff2a2022e67da3f9f525f9087cf2de507.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202511@1575012). Learn more about missing BASE report.

Files with missing lines Patch % Lines
SecurityPkg/Tcg/Tcg2AcpiFfa/Tcg2AcpiFfa.c 0.00% 9 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202511   #1798   +/-   ##
================================================
  Coverage                  ?   1.59%           
================================================
  Files                     ?     160           
  Lines                     ?   37730           
  Branches                  ?     172           
================================================
  Hits                      ?     601           
  Misses                    ?   37129           
  Partials                  ?       0           
Flag Coverage Δ
SecurityPkg 1.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mu-automation
Copy link
Copy Markdown
Contributor

mu-automation Bot commented May 14, 2026

⏩ QEMU Validation Skipped

The PR was merged before validation completed.

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@kuqin12 kuqin12 merged commit 07ff0dc into release/202511 May 14, 2026
56 checks passed
@kuqin12 kuqin12 deleted the revert_revert branch May 14, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants