DxeImageVerificationLib rewrite#1796
Draft
Javagedes wants to merge 9 commits into
Draft
Conversation
Add skills files and rearchitecture documentation
Adds two additional fields of PE_COFF_LOADER_IMAGE_CONTEXT: 1. `DataDirectoryRead`: An optional caller provided callback to to execute code on the given `EFI_IMAGE_DATA_DIRECTORY` 2. `DataDirectoryReadContext`: An optional caller provided opaque pointer that can be used by `DataDirectoryRead`.
Adds a API to the BaseCryptLib Library that accepts a image buffer and a hash type guid and returns a digest buffer and size.
merge into boilerplate
Adds the Policy verification implementation and security data directory lookup to determine the image validation path to follow (ValidateUnsignedImage or ValidateSignedImage).
Add unit tests for support code in Policy.c and Support.c
Javagedes
changed the title
Contributor
⌛ QEMU Validation PendingQEMU validation is pending on successful CI completion.
This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Javagedes
force-pushed
the
personal/joeyvagedes/cryptopkg-image-verify
branch
from
ea9878b to
9169502
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1796 +/- ##
=================================================
Coverage ? 1.07%
=================================================
Files ? 1473
Lines ? 377494
Branches ? 4777
=================================================
Hits ? 4056
Misses ? 372559
Partials ? 879
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A rewrite of
DxeImageVerificationLib. This is a WIP (ValidateSignedImageand Config Table manipulation have not yet been implemented).It is suggested you look at each commit instead of reviewing the PR as a whole.
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>