[Rebase & FF] .pytool: Image Validation Plugin: Drop Zero ImageBase Requirement#1793
Merged
vineelko merged 2 commits intoMay 13, 2026
Conversation
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/25768892026 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Javagedes
reviewed
May 12, 2026
Contributor
Javagedes
left a comment
Javagedes
left a comment
There was a problem hiding this comment.
Can you make this a REBASE&FF so that line endings are a different commit then the line changes?
Contributor
Author
|
The modified files had not been changed since 2022, and the repository added an |
os-d
reviewed
May 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1793 +/- ##
=================================================
Coverage ? 2.21%
=================================================
Files ? 1633
Lines ? 420069
Branches ? 4949
=================================================
Hits ? 9308
Misses ? 410686
Partials ? 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vineelko
force-pushed
the
users/vineelko/minor_fix_support_non_zero_image_base_0512
branch
from
e92fd75 to
85af036
Compare
- This is needed to be in sync with `.editorconfig` Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
- Zero ImageBase requirement is dropped from Image validation plugin as it is not enforced by most PE loaders in UEFI. - Patina in particular dropped support for producing .efi files with zero ImageBase - This also improves the debugging experience when using WinDbg Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
vineelko
force-pushed
the
users/vineelko/minor_fix_support_non_zero_image_base_0512
branch
from
85af036 to
caba185
Compare
vineelko
changed the title
makubacki
approved these changes
May 12, 2026
apop5
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How This Was Tested
Q35
Integration Instructions
NA