-
Notifications
You must be signed in to change notification settings - Fork 50
FIX: Accept Row objects in bulkcopy without manual tuple conversion #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jahnvi480
wants to merge
8
commits into
main
Choose a base branch
from
jahnvi/github_issue_482
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−4
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
80f77d0
Accept Row objects in bulkcopy without manual tuple conversion (GH-482)
jahnvi480 48f972c
Merge branch 'main' into jahnvi/github_issue_482
jahnvi480 cc05a41
FIX: executemany SQL_C_NUMERIC mismatch (#611)
jahnvi480 6af198e
FIX: always statically link simdutf via FetchContent (#608)
edgarrmondragon f897890
FIX: Flaky tests in CI and mark stress tests (#617)
bewithgaurav db59fa9
DOC: Revise target timelines for roadmap features (#510)
sumitmsft cfad9f7
Address review: remove list branch, fix type hint and docstring (GH-482)
jahnvi480 44631c6
Merge branch 'main' into jahnvi/github_issue_482
jahnvi480 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this helper is pure Python and testable without a SQL connection. a small unit test would lock down the Row/list/tuple/TypeError behavior and prevent silent regressions.