Trim trailing empty rows/columns from Excel sheets to prevent OOM#1638
Open
spencerogden-dsam wants to merge 1 commit intomicrosoft:mainfrom
Open
Trim trailing empty rows/columns from Excel sheets to prevent OOM#1638spencerogden-dsam wants to merge 1 commit intomicrosoft:mainfrom
spencerogden-dsam wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Excel files (especially .xls) often pad to fixed dimensions (256 columns, 65536 rows) even when only a few cells contain data. When every empty cell is rendered through to_html() → Markdown, this causes extreme memory usage and enormous output. A real-world 57 KB .xls file produced 95 MB of Markdown (1,700x expansion) and consumed 13+ GB of RAM. This trims trailing all-NaN rows and columns before calling to_html(). Only trailing empties are removed, preserving intentional blank rows or columns used as visual separators within the data area. Applied to both XlsxConverter and XlsConverter.
Author
|
@microsoft-github-policy-service agree company="Dock Street Asset Management"
…--
Spencer Ogde n
President
***@***.***
Phone/Text: 203.532.9470 ( tel:+12035329470 )
DOCK STREET ASSET MANAGEMENT
Palm Beach, FL • Newport, RI
This email, including attachments, may include confidential and/or proprietary information, and may be used only by the person or entity to which it is addressed. If the reader of this email is not the intended recipient or their authorized agent, the reader is hereby notified that any dissemination, distribution or copying of this email is prohibited. If you have received this email in error, please notify the sender by replying to this message and delete this email immediately.
On Thu, Mar 26, 2026 at 11:18 AM, microsoft-github-policy-service[bot] < ***@***.*** > wrote:
*microsoft-github-policy-service[bot]* left a comment (microsoft/ markitdown#1638)
(
#1638?email_source=notifications&email_token=AP7WID2W3WRSX4FE7N5NWRD4SVC4RA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGU4DQNBQGQ32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4135884047
)
@ spencerogden-dsam ( https://github.com/spencerogden-dsam ) please read
the following Contributor License Agreement(CLA). If you agree with the
CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
>
>
> Options:
>
>
>
> * (default - no company specified) I have sole ownership of intellectual
> property rights to my Submissions and I am not making Submissions in the
> course of work for my employer.
>
>
> @microsoft-github-policy-service agree
>
>
> * (when company given) I am making Submissions in the course of work for
> my employer (or my employer has intellectual property rights in my
> Submissions by contract or applicable law). I have permission from my
> employer to make Submissions and enter into this Agreement on behalf of my
> employer. By signing below, the defined term “You” includes me and my
> employer.
>
>
> @microsoft-github-policy-service agree company="Microsoft"
>
Contributor License Agreement
Contribution License Agreement
------------------------------
This Contribution License Agreement ( *“Agreement”* ) is agreed to by the
party signing below ( *“You”* ),
and conveys certain license rights to Microsoft Corporation and its
affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is
effective as of the latest signature
date below.
* *Definitions*.
*“Code”* means the computer software code, whether in human-readable or
machine-executable form,
that is delivered by You to Microsoft under this Agreement.
*“Project”* means any of the projects owned or managed by Microsoft and
offered under a license
approved by the Open Source Initiative ( www. opensource. org (
http://www.opensource.org ) ).
*“Submit”* is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic mailing
lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of,
the Project for the purpose of
discussing and improving that Project, but excluding communication that is
conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
*“Submission”* means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
* *Your Submission*. You must agree to the terms of this Agreement before
making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in
the future (except as
described in Section 4 below), Submit to any Project.
* *Originality of Work*. You represent that each of Your Submissions is
entirely Your original work.
Should You wish to Submit materials that are not Your original work, You
may Submit them separately
to the Project if You (a) retain all copyright and license information
that was in the materials as You
received them, (b) in the description accompanying Your Submission,
include the phrase “Submission
containing materials of a third party:” followed by the names of the third
party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions
in the Project’s written
guidelines concerning Submissions.
* *Your Employer*. References to “employer” in this Agreement include Your
employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor,
vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You must
secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change
employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
* *Licenses*.
* *Copyright License*. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display,
publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of
the foregoing rights to third
parties.
* *Patent License*. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the
combination of the
Submission with the Project to which it was Submitted to make, have made,
use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
* *Other Rights Reserved*. Each party reserves all rights not expressly
granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
* *Representations and Warranties*. You represent that You are legally
entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the course
of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You
choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER
THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY
WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
* *Notice to Microsoft*. You agree to notify Microsoft in writing of any
facts or circumstances of which
You later become aware that would make Your representations in this
Agreement inaccurate in any
respect.
* *Information about Submissions*. You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
* *Governing Law/Jurisdiction*. This Agreement is governed by the laws of
the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which
case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
* *Entire Agreement/Assignment*. This Agreement is the entire agreement
between the parties, and
supersedes any and all prior agreements, understandings or communications,
written or oral, between
the parties relating to the subject matter hereof. This Agreement may be
assigned by Microsoft.
—
Reply to this email directly, view it on GitHub (
#1638?email_source=notifications&email_token=AP7WID2W3WRSX4FE7N5NWRD4SVC4RA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJTGU4DQNBQGQ32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4135884047
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AP7WID7MCBONDU6PWQNV4VL4SVC4RAVCNFSM6AAAAACXATDONSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMZVHA4DIMBUG4
).
You are receiving this because you were mentioned. Message ID: <microsoft/markitdown/pull/1638/c4135884047
@ github. com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excel files (especially
.xlsformat) often pad sheets to fixed dimensions (256 columns, 65,536 rows) even when only a few cells contain data. When every empty cell is rendered throughDataFrame.to_html()→HtmlConverter, this causes extreme memory usage and enormous output.Real-world example: A 57 KB
.xlsfile with ~5 data columns padded to 256 columns produced 95 MB of Markdown (1,700x expansion) and consumed 13+ GB of RAM during conversion, causing OOM kills in production.Fix
Added
_trim_trailing_empty()which trims trailing all-NaN rows and columns from each sheet's DataFrame before callingto_html(). Applied to bothXlsxConverterandXlsConverter.Only trailing empties are removed — intentional blank rows or columns used as visual separators within the data area are preserved.
Before/After
Test plan
🤖 Generated with Claude Code