fix: initialize res to None to prevent UnboundLocalError#1621
Open
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Open
fix: initialize res to None to prevent UnboundLocalError#1621Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Jah-yee wants to merge 2 commits intomicrosoft:mainfrom
Conversation
- Add helper function _format_cell_value() to preserve currency symbols - Support for USD ($), EUR (€), GBP (£), JPY (¥), and other currencies - Support for percentage formatting - Preserve decimal places from number format - Use openpyxl directly instead of pandas for better format control Fixes microsoft#53
Fixes issue microsoft#81 - UnboundLocalError when no converter accepts the file. The variable res was only set inside the 'if _accepts:' block, but was checked later outside of it. When no converter accepts the file, res would be undefined, causing UnboundLocalError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #81 - UnboundLocalError when no converter accepts the file.
The variable
reswas only set inside theif _accepts:block, but was checked later outside of it. When no converter accepts the file,reswould be undefined, causing UnboundLocalError.This is a one-line fix that initializes
res = Nonebefore the converter loop.