Fix ZIP filename encoding for Chinese and Japanese files#1535
Open
mizuresort wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix ZIP filename encoding for Chinese and Japanese files#1535mizuresort wants to merge 1 commit intomicrosoft:mainfrom
mizuresort wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
|
This PR works for me. It fixes my issue #1506 |
Author
|
Thanks for linking your issue and confirming the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes garbled ZIP filenames for non-UTF8 encodings.
It normalizes ZIP entry names by trying multiple encodings:
It also skips macOS metadata files (e.g., _MACOSX/, . files)
to avoid showing non-user content.
This allows international filenames to be displayed correctly.