Bump versions of mammoth and pdfminer.six (#1492)#1521
Conversation
* Updated pyproject to require a minimum version of pdfminer.six to ensure CVE-2025-64512 is patched.
|
@jarlungoodoo73 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
ORCID can be used or no |
There was a problem hiding this comment.
Pull request overview
This PR attempts to add a minimum version constraint for the pdfminer.six dependency to patch CVE-2025-64512 and bumps the package version from 0.1.3 to 0.1.4. However, there are several critical issues that need to be addressed.
Key Changes:
- Package version bumped from 0.1.3 to 0.1.4
- Added minimum version constraint for pdfminer.six (>=20251107) in the "all" optional dependencies
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/markitdown/src/markitdown/__about__.py |
Bumps package version to 0.1.4 |
packages/markitdown/pyproject.toml |
Adds minimum version constraint for pdfminer.six to address CVE-2025-64512 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "xlrd", | ||
| "lxml", | ||
| "pdfminer.six", | ||
| "pdfminer.six>=20251107", |
There was a problem hiding this comment.
The version constraint for pdfminer.six has been added to the "all" optional dependencies group, but the "pdf" optional dependency group on line 56 still references pdfminer.six without a version constraint. For consistency and to ensure the CVE patch is applied when users install with the "pdf" extra, this line should also be updated to "pdfminer.six>=20251107" (pending verification of the correct version number).
| "xlrd", | ||
| "lxml", | ||
| "pdfminer.six", | ||
| "pdfminer.six>=20251107", |
There was a problem hiding this comment.
The PR title mentions bumping versions of both "mammoth and pdfminer.six", but the code changes only update the version constraint for pdfminer.six. The mammoth version remains at ~=1.11.0 (lines 39 and 53 in pyproject.toml). Either the PR title should be updated to reflect only the pdfminer.six change, or the mammoth version should also be bumped if that was the original intent.
* Updated pyproject to require a minimum version of pdfminer.six to ensure CVE-2025-64512 is patched.
Have we got a patch, l am creating to many actions here. All is it 9k, Questions Thogjuts Git. Please