Add tests for file URIs on Windows#1507
Open
oxygen-dioxide wants to merge 2 commits intomicrosoft:mainfrom
Open
Add tests for file URIs on Windows#1507oxygen-dioxide wants to merge 2 commits intomicrosoft:mainfrom
oxygen-dioxide wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Added Windows-specific tests for file URIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
test_file_uris()contained POSIX-specific expectations and always fail on Windows. This change splits that test into two platform-specific tests:test_file_uris_posix()andtest_file_uris_windows(), each guarded withpytest.mark.skipifso they only run on the appropriate platform.What changed
test_file_uris_posix()(runs only when sys.platform != "win32")test_file_uris_windows()(runs only when sys.platform == "win32")