fix: implement NOT operator with LINQ post-filtering #1109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the NOT operator issues - the NOT operator now works correctly using a hybrid FTS + LINQ approach.
Problem
The NOT operator had two problems:
km search "NOT foo"threw FTS5 syntax errorkm search "foo AND NOT bar"returned documents containing bothSolution
Hybrid FTS + LINQ filtering:
Changes
src/Core/Search/NodeSearchService.cs:FtsQueryResultrecord to separate FTS query from NOT termsFtsQueryExtractorto collect NOT terms separatelyApplyNotTermFiltering()for LINQ exclusionsrc/Core/Search/SqliteFtsIndex.cs:GetAllDocumentsAsync()for standalone NOT queriessrc/Core/Search/Query/Parsers/InfixQueryParser.cs:'AND'as literal with quotes)src/Main/CLI/Commands/ExamplesCommand.cs:tests/Core.Tests/Search/SearchEndToEndTests.cs:KNOWN-ISSUES.md: Cleaned up, only open issues remainUsage
Note: Use explicit AND between terms (e.g.,
foo AND NOT bar)Test plan
build.shpasses with 0 warningsformat.shpasses