test(linting): update mock scoping to target LintingHelpers module#405
Closed
shaominngqing wants to merge 1 commit intomicrosoft:mainfrom
Closed
test(linting): update mock scoping to target LintingHelpers module#405shaominngqing wants to merge 1 commit intomicrosoft:mainfrom
shaominngqing wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Add -ModuleName LintingHelpers to all mocks of extracted functions - Affects Get-ChangedFilesFromGit, Get-FilesRecursive, Write-GitHubAnnotation, Set-GitHubOutput, Set-GitHubEnv, and Write-GitHubStepSummary - Ensures mocks target the correct function scope after refactoring in microsoft#379 Fixes microsoft#396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates mock scoping in linting tests following the refactoring in #379 where shared boilerplate functions were extracted into
LintingHelpers.psm1.Without specifying
-ModuleName LintingHelpers, mocks may not target the correct function scope, potentially causing test failures.Changes
-ModuleName LintingHelpersparameter to all mocks of functions from the LintingHelpers module:Get-ChangedFilesFromGitGet-FilesRecursiveWrite-GitHubAnnotationSet-GitHubOutputSet-GitHubEnvWrite-GitHubStepSummaryFiles Modified
scripts/tests/linting/Invoke-PSScriptAnalyzer.Tests.ps1scripts/tests/linting/Invoke-YamlLint.Tests.ps1Testing
Fixes #396