refactor(security): move DependencyViolation and ComplianceReport to shared module #378
+142
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shared module Resolves microsoft#324 - Create scripts/security/Modules/SecurityClasses.psm1 with: - DependencyViolation class with constructor overloads - ComplianceReport class with helper methods (AddViolation, CalculateScore, ToHashtable) - Documentation and examples - Update Test-DependencyPinning.ps1: - Add 'using module' import for SecurityClasses.psm1 - Remove inline class definitions (~35 lines) This follows the pattern established by FrontmatterValidation.psm1 and improves reusability and testability of the security scanning infrastructure.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 62.21% 60.93% -1.28%
==========================================
Files 18 19 +1
Lines 3202 3233 +31
==========================================
- Hits 1992 1970 -22
- Misses 1210 1263 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- add copyright and SPDX-License-Identifier header - remove date from header comment - clarify export comment for module classes 🔧 - Generated by Copilot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #324
Moves inline class definitions from
Test-DependencyPinning.ps1to a dedicated module for improved reusability and testability.Changes
New:
scripts/security/Modules/SecurityClasses.psm1DependencyViolationclass - represents a single pinning violationComplianceReportclass - aggregates violations and generates reportsAddViolation()methodCalculateScore()methodToHashtable()method for serializationUpdated:
Test-DependencyPinning.ps1using moduleimport for SecurityClasses.psm1Testing
npm run lint:ps- PSScriptAnalyzer passesnpm run test:ps- All Pester tests pass (779 passed)Notes
Follows the pattern established by
FrontmatterValidation.psm1in the linting modules.