go.mod: bump containerd/cgroups#828
Conversation
|
Hi, unfortunately, this is a breaking change due to the api break mentioned here golang/go#34610. We would additionally need to update https://github.com/microsoft/go-winio and fix breaking changes there in order to take this. |
Yeah, I see that :-( Let's see how easy it is to fix this. |
|
Hmm, unless I'm missing something big the fix was relatively easy; please see the second commit @katiewasnothere |
|
I'm made a new PR for the necessary go-winio changes here microsoft/go-winio#172 fyi |
|
This looks good to me. Could you squash the commits into one? |
This is mostly to update dependencies. Since we have updated x/sys/windows, make cmd/containerd-shim-runhcs-v1 use the new windows.SecurityDescriptorFromString(), removing the ugly unsafe cast. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
sure, done @katiewasnothere |
This is mostly to update dependencies.