Skip to content

Fix win32File.socket flag and add TestHvSockFlagIsSet #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maishivamhoo123 wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

Fix win32File.socket flag and add TestHvSockFlagIsSet #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
319cecc
Fix win32File.socket flag and add TestHvSockFlagIsSet
maishivamhoo123 Jan 8, 2026
e4a27c4
Fix lint: explicitly ignore Closesocket error
maishivamhoo123 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ func (f *win32File) closeHandle() {
_ = cancelIoEx(f.handle, nil)
f.wg.Wait()
// at this point, no new IO can start
windows.Close(f.handle)
if f.socket {
_ = windows.Closesocket(f.handle)
} else {
windows.Close(f.handle)
}
f.handle = 0
} else {
f.wgLock.Unlock()
Expand Down
7 changes: 7 additions & 0 deletions hvsock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,3 +671,10 @@ func mustBeType[T any](tb testing.TB, v any) T {
}
return v2
}
func TestHvSockFlagIsSet(t *testing.T) {
u := newUtil(t)
cl, sv, _ := clientServer(u)

u.Assert(cl.sock.socket, "Client win32File.socket should be true")
u.Assert(sv.sock.socket, "Server win32File.socket should be true")
}