fix dangerous uintptr conversion#335
Open
dangodangodango wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
e85e572 to
e2decbe
Compare
Signed-off-by: litmxs <litmxs@gmail.com>
e2decbe to
3f8cb5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to: https://pkg.go.dev/unsafe#Pointer
Unsafe.Pointerrule 4:Storing a go pointer to
uintptrvariable is dangerous, the address of the go variable that theuintptrpointers to may change (stack grow), or the variable be garbage-collected(uintptrdoesn't ref the value).Even worse, the original address may be reused by another goroutine, and if the syscall writes to that address, it's can cause memory corruption and random runtime errors.