Add option to allow remote access to pipe#333
Open
christian-korneck wants to merge 1 commit intomicrosoft:mainfrom
Open
Add option to allow remote access to pipe#333christian-korneck wants to merge 1 commit intomicrosoft:mainfrom
christian-korneck wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Signed-off-by: Christian Korneck <christian@korneck.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently not possible with
go-winioto expose a named pipe for remote access (SMB).This PR adds a new bool field
AcceptRemoteClientsto thePipeConfigstruct that allows to optionally enable remote access. Defaults to false, which maintains existing behavior.(I intentionally did not add a new test as it would require a smb client (would add bloat), but I have confirmed that remote access works using the go-smb package.)