fix linting issues

[thaJeztah]

• relates to Fix deadlock when closing pipe #324 (comment)

[thaJeztah]

cc @kevpar if you have permissions to kick CI ❤️

[katiewasnothere]

@thaJeztah It looks like the CI is still failing

[thaJeztah]

Yeah, I noticed; I suspect the other failures may also be with newer go versions, or updated golangci-lint.

I think they're all about integer conversion in generated code; haven't checked if they can be ignored (temporarily) or need fixing;

mode=readonly] in [] ...
  ::high file=wim/lzx/lzx.go,line=137,col=13::G115: integer overflow conversion uint32 -> uint16 (gosec)
  ::high file=wim/lzx/lzx.go,line=191,col=26::G115: integer overflow conversion uint -> uint16 (gosec)
  ::high file=wim/lzx/lzx.go,line=200,col=38::G115: integer overflow conversion int -> uint16 (gosec)
  ::high file=wim/lzx/lzx.go,line=376,col=20::G115: integer overflow conversion uint32 -> uint16 (gosec)
  ::high file=wim/lzx/lzx.go,line=377,col=20::G115: integer overflow conversion uint32 -> uint16 (gosec)
  ::high file=wim/lzx/lzx.go,line=378,col=20::G115: integer overflow conversion uint32 -> uint16 (gosec)
  ::high file=wim/lzx/lzx.go,line=526,col=51::G115: integer overflow conversion int -> uint16 (gosec)

[mat007]

I opened a separate PR to fix the «Go Generate» failure: #326

[kiashok]

CI is still failing

[kiashok]

@mat007 @thaJeztah looks like the CIs are still failing

[mat007]

Maybe these should be pinned versions? 🤷

go-winio/.github/workflows/ci.yml

Lines 7 to 9 in bdc6c11

	GO_VERSION: "oldstable"
	GOTESTSUM_VERSION: "latest"
	GOLANGCILINT_VERSION: "latest"

[mat007]

There are 104 linting errors remaining, all due to conversions. I’ve looked at a few and they all seem to be similar, for instance

go-winio/pkg/etw/fieldopt.go

Line 165 in bdc6c11

ed.writeUint16(uint16(len(values)))

raises

  ::high file=pkg/etw/fieldopt.go,line=165,col=24::G115: integer overflow conversion int -> uint16 (gosec)

What would be best here? To «nolint» them all?

[thaJeztah]

I added a global ignore for this one for now; I think most of these are likely false positives in generated code, but would have to be reviewed by someone with more understanding of those parts of the code.

[thaJeztah]

Pushed some changes, but I don't have a windows machine to verify on locally, but if someone could kick CI again ❤️ @kiashok @katiewasnothere