tools/mkwinsyscall: remove errnoERROR_IO_PENDING const#260
Open
thaJeztah wants to merge 1 commit intomicrosoft:mainfrom
Open
tools/mkwinsyscall: remove errnoERROR_IO_PENDING const#260thaJeztah wants to merge 1 commit intomicrosoft:mainfrom
thaJeztah wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
helsaawy
approved these changes
Oct 11, 2022
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
From what i am able to tell, errnoERROR_IO_PENDING was originally added for WSAEINPROGRESS, which leads me to believe it was added like the because syscall doesnt define it as an error number:
https://go-review.googlesource.com/c/go/+/28484/4/src/syscall/mksyscall_windows.go
Since windows defers tosyscall.Errno, this shouldnt cause weird type conversion issues either....
helsaawy
requested changes
Oct 11, 2022
Contributor
helsaawy
left a comment
helsaawy
left a comment
There was a problem hiding this comment.
you will need to add a "windowsdot": windowsdot, line in the funcMap on line 852 so that windowsdot in the template works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the looks of it, this const is redundant (but perhaps there's something I'm overlooking 😅)