Skip to content

feat(react-accordion): [CAP] use bundleIcon for AccordionHeader expand icon #35934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GianoglioEnrico wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(react-accordion): [CAP] use bundleIcon for AccordionHeader expand icon #35934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...-components/react-accordion/library/src/components/AccordionHeader/useAccordionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@ import type {
AccordionHeaderState,
Copy link
Copy Markdown

@github-actions github-actions bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png 404 Changed
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png 413 Changed
vr-tests-react-components/Positioning 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.chromium.png 617 Changed
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 845 Changed
vr-tests-react-components/ProgressBar converged 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png 77 Changed
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png 45 Changed

There were 1 duplicate changes discarded. Check the build logs for more information.

} from './AccordionHeader.types';
import { useAccordionContext_unstable } from '../../contexts/accordion';
import { ChevronRightRegular } from '@fluentui/react-icons';
import { bundleIcon, ChevronRightFilled, ChevronRightRegular } from '@fluentui/react-icons';
import { useFluent_unstable as useFluent } from '@fluentui/react-shared-contexts';
import { useAccordionItemContext_unstable } from '../../contexts/accordionItem';
import { motionTokens } from '@fluentui/react-motion';

const ChevronRightIcon = bundleIcon(ChevronRightFilled, ChevronRightRegular);

/**
* Returns the props and state required to render the component
*
Expand All @@ -41,7 +43,7 @@ export const useAccordionHeader_unstable = (

if (state.expandIcon) {
state.expandIcon.children ??= (
<ChevronRightRegular
<ChevronRightIcon
style={{
transform: `rotate(${expandIconRotation}deg)`,
transition: `transform ${motionTokens.durationNormal}ms ease-out`,
Expand Down
3 changes: 3 additions & 0 deletions ...react-accordion/library/src/components/AccordionHeader/useAccordionHeaderStyles.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { createFocusOutlineStyle } from '@fluentui/react-tabster';
import { tokens, typographyStyles } from '@fluentui/react-theme';
import type { AccordionHeaderSlots, AccordionHeaderState } from './AccordionHeader.types';
import type { SlotClassNames } from '@fluentui/react-utilities';
import { iconFilledClassName, iconRegularClassName } from '@fluentui/react-icons';

export const accordionHeaderClassNames: SlotClassNames<AccordionHeaderSlots> = {
root: 'fui-AccordionHeader',
Expand Down Expand Up @@ -83,6 +84,8 @@ const useStyles = makeStyles({
alignItems: 'center',
lineHeight: tokens.lineHeightBase500,
fontSize: tokens.fontSizeBase500,
[`:hover .${iconFilledClassName}`]: { display: 'inline' },
[`:hover .${iconRegularClassName}`]: { display: 'none' },
},
expandIconStart: {
paddingRight: tokens.spacingHorizontalS,
Expand Down
Loading