Skip to content

Fix dir in Provider Context to prefer existing dir #35702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anarmawala wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −1
Open

Fix dir in Provider Context to prefer existing dir #35702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
430bcd7
fix dir in Provider Context
anarmawala Jan 27, 2026
75ce8a9
changelogs
anarmawala Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-shared-contexts-5cab9ef3-e76e-4fce-a1ba-5e82071c543c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Copy link

@github-actions github-actions bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png 5 Changed
vr-tests-react-components/Charts-DonutChart 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Charts-DonutChart.Dynamic.default.chromium.png 5581 Changed
vr-tests-react-components/Positioning 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 33 Changed
vr-tests-react-components/TagPicker 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png 658 Changed

There were 1 duplicate changes discarded. Check the build logs for more information.

"type": "minor",
"comment": "Make sure the dir based on existing document dir",
"packageName": "@fluentui/react-shared-contexts",
"email": "anarmawala@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion ...ges/react-components/react-shared-contexts/library/src/ProviderContext/ProviderContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const ProviderContext = React.createContext<ProviderContextValue | undefined>(
const providerContextDefaultValue: ProviderContextValue = {
// eslint-disable-next-line @nx/workspace-no-restricted-globals -- expected ignore ( SSR friendly acquisition of globals )
targetDocument: typeof document === 'object' ? document : undefined,
dir: 'ltr' as const,
dir: (typeof document === 'object' && (document.dir === 'rtl' ? 'rtl' : 'ltr')) || 'ltr',
};

/**
Expand Down
Loading