Move FocusZone away from bridge#4067
Conversation
🦋 Changeset detectedLatest commit: 613c9ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Talked offline, but this does a lot more than make it a Turbomodule, it moves FocusZone to the V1 framework which is orthogonal |
JunielKatarn
changed the title
JunielKatarn
force-pushed
the
focuszone-tm
branch
from
ebae210 to
f993ed1
Compare
| // defaultTabbableElement is not handled here: resolving a view by React tag | ||
| // requires the legacy UIManager and is not supported in the Fabric renderer. |
There was a problem hiding this comment.
@acoates-ms any idea how one might be able to do this, suppose of you had to do it for windows?
There was a problem hiding this comment.
In windows we still have a look up by tag in fabric. -- That may not have been the correct move if that isn't available in the other platforms.
Also didn't we move to saying this property should be set using nativeId? - Maybe we'll have to force all SDXs to only use that method when using fabric?
There was a problem hiding this comment.
Talked offline a bit more, I think we should update this to handle setting by nativeID. And we'll need to make it backwards compatible too since internally, the JS and native code may not be in sync.
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| "@fluentui-react-native/focus-zone": major | |||
There was a problem hiding this comment.
We disallow major bumps in the repo as of now, and this should be additive not breaking. So I don' think this should be major.
3 participants
Platforms Impacted
Description of changes
Migrate the FocusZoneViewManager module to TurboModule semantics.
Verification
Ran existing tests.
Pull request checklist
This PR has considered (when applicable):