-
Notifications
You must be signed in to change notification settings - Fork 227
NAT Gateway for private subnets (fixes #2161) #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+333
−125
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
69a96b1
fix(finops-hub): add NAT Gateway to private subnets (#2161)
affa942
Make NAT Gateway opt-in via enableNatGateway parameter
79c7832
Add -NetworkMode to Deploy-FinOpsHub and Deploy-Hub scripts
b12c7dd
Address Copilot review: conditional dependsOn + NAT/PIP tag namespaces
4ffb342
fix(powershell): gate enableNatGateway to v15.0+ to prevent ARM error…
58e45a4
fix(hubs): correct vNet tag namespace, conditional NAT gateway, and p…
MSBrett 565070e
fix(hubs): scope enableNatGateway to private mode and add NetworkMode…
MSBrett ad49b54
Merge remote-tracking branch 'origin/dev' into fix/subnet-default-out…
MSBrett 27706d7
chore: trigger PR mergeability recompute
MSBrett 7049c4c
Merge origin/dev into fix/subnet-default-outbound-access
2b4d188
Fix Pester test compatibility
2a3b655
Migrate legacy Pester mock assertions
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.