docs-mslearn: remove broken external links and add DocsLinks guardrails#2141
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/finops-toolkit/sessions/966e7305-52d7-4afc-a3d9-7f54676259c9 Co-authored-by: MSBrett <24294904+MSBrett@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/finops-toolkit/sessions/966e7305-52d7-4afc-a3d9-7f54676259c9 Co-authored-by: MSBrett <24294904+MSBrett@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/finops-toolkit/sessions/966e7305-52d7-4afc-a3d9-7f54676259c9 Co-authored-by: MSBrett <24294904+MSBrett@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/finops-toolkit/sessions/231bd2bf-9bcb-4b1a-9ec7-958f98fbd94e Co-authored-by: MSBrett <24294904+MSBrett@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/finops-toolkit/sessions/231bd2bf-9bcb-4b1a-9ec7-958f98fbd94e Co-authored-by: MSBrett <24294904+MSBrett@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
Needs: Review 👀
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up broken external links in the docs-mslearn content set and adds Pester guardrails to prevent regressions by failing CI when known-bad external URLs or incomplete placeholder URLs reappear.
Changes:
- Added DocsLinks test cases to detect specific known-broken external URLs and incomplete
https://ccmstorageprod...placeholder URLs in docs-mslearn. - Replaced/removed broken external links in docs-mslearn (FinOps Foundation deep links,
aka.msschema link, and a managed disks product link). - Updated docs metadata dates and replaced the placeholder
ccmstorageprodURL with the fully qualified blob URL where applicable.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/powershell/Tests/Unit/DocsLinks.Tests.ps1 | Adds regression guardrails (Pester -ForEach cases) to fail if known broken/incomplete external URLs appear in docs-mslearn. |
| docs-mslearn/toolkit/power-bi/setup.md | Replaces the incomplete ccmstorageprod placeholder with the full blob URL and updates ms.date. |
| docs-mslearn/toolkit/hubs/deploy.md | Replaces the incomplete ccmstorageprod placeholder with the full blob URL and updates ms.date. |
| docs-mslearn/toolkit/changelog.md | Removes a known-broken aka.ms link reference and updates ms.date. |
| docs-mslearn/framework/quantify/benchmarking.md | Replaces a broken FinOps Foundation deep link with a stable framework root link and updates ms.date. |
| docs-mslearn/framework/manage/onboarding.md | Replaces a broken FinOps Foundation deep link with a stable framework root link and updates ms.date. |
| docs-mslearn/best-practices/storage.md | Removes a broken managed disks product page link and updates ms.date. |
RolandKrummenacher
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2139.
Replaces #2140, which could not be reopened because its original head branch was deleted.
Restores the same PR changes from inactive pull request ref #2140.
Includes: