Skip to content

Comments

Revert Claude Code plugin PR #2013#2023

Merged
flanakin merged 2 commits intodevfrom
revert/pr-2013
Feb 25, 2026
Merged

Revert Claude Code plugin PR #2013#2023
flanakin merged 2 commits intodevfrom
revert/pr-2013

Conversation

@flanakin
Copy link
Collaborator

@flanakin flanakin commented Feb 25, 2026

Summary

Reverts #2013 ("Add Claude Code plugin for FinOps hubs and Azure Cost Management") which was merged without full review. See PR #2013 review comments for details.

Key issues:

  • CLAUDE.md was replaced with Copilot instructions content instead of the original Claude Code guidance (build commands, architecture, dev patterns)
  • Packaging would be brokenPackage-Toolkit.ps1 doesn't follow symlinks
  • Commands reference nonexistent paths and lack guardrails for token consumption
  • Versioning and repo structure issues — marketplace.json at root, plugin version mismatch

The plugin work is valuable and should be re-submitted after addressing review feedback.

Test plan

  • Verify CLAUDE.md is restored to original content
  • Verify no build/test regressions
  • ❎ Log not needed

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings February 25, 2026 06:05
@flanakin flanakin requested a review from MSBrett as a code owner February 25, 2026 06:05
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Feb 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts PR #2013 which added a Claude Code plugin for the FinOps toolkit. The revert is being performed because post-merge review identified several issues including: replacement of CLAUDE.md with a symlink, improper file placement, symlink packaging concerns, lack of guardrails in autonomous commands, unverified content, and changelog version inconsistencies. The revert removes approximately 5,000+ lines of plugin-related code including agents, skills, commands, and reference documentation.

Changes:

  • Restores original CLAUDE.md with 182 lines of build commands, architecture docs, and development patterns
  • Removes entire Claude Code plugin directory and all associated files (agents, skills, commands, references)
  • Removes marketplace.json and AGENTS.md symlink from repository root
  • Removes Claude Code plugin v1.0 changelog entry from docs-mslearn/toolkit/changelog.md

Reviewed changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
CLAUDE.md Restored from symlink to full 182-line original content with build commands and architecture docs
AGENTS.md Removed symlink to copilot-instructions.md
.claude-plugin/marketplace.json Removed marketplace configuration file
src/templates/claude-plugin/* Removed entire plugin directory including skills, agents, commands, and references
src/queries/catalog/costs-enriched-base.kql Updated documentation URL (contains hardcoded branch reference - see comment)
src/queries/catalog/quarterly-cost-by-resource-group.kql Updated query description comments
src/queries/finops-hub-database-guide.md Changed reference from specific catalog query to generic "CostsPlus Query"
docs-mslearn/toolkit/changelog.md Removed Claude Code plugin v1.0 changelog entry

@flanakin flanakin enabled auto-merge (squash) February 25, 2026 06:43
@flanakin flanakin merged commit 1375650 into dev Feb 25, 2026
4 checks passed
@flanakin flanakin deleted the revert/pr-2013 branch February 25, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants