Add parameters for noisy recommendations and rename query files

[flanakin]

🛠️ Description

Add enableAHBRecommendations and enableSpotRecommendations parameters to control noisy recommendation types independently. Also renames query files to follow Recommendations-Microsoft-* naming convention, adds a recommendations tab to createUiDefinition.json for the Azure portal deployment experience, and switches enableRecommendations to default off (preview).

Fixes # N/A

📋 Checklist

🔬 How did you test this change?

• 🤏 Lint tests
• 🤞 PS -WhatIf / az validate
• 👍 Manually deployed + verified
• 💪 Unit tests
• 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

• 🚨 This is a breaking change.
• 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

• ✅ Updated changelog (required for dev PRs)
• ➡️ Will add log in a future PR (feature branch PRs only)
• ❎ Log not needed (small/internal change)

📖 Did you update documentation?

• ✅ Public docs in docs (required for dev)
• ✅ Public docs in docs-mslearn (required for dev)
• ✅ Internal dev docs in docs-wiki (required for dev)
• ✅ Internal dev docs in src (required for dev)
• ➡️ Will add docs in a future PR (feature branch PRs only)
• ❎ Docs not needed (small/internal change)

[Copilot]

Pull request overview

This PR enhances the FinOps hubs recommendations feature by adding granular control over potentially noisy recommendation types, standardizing naming conventions, and improving the deployment experience through the Azure portal UI.

Changes:

• Added enableAHBRecommendations and enableSpotRecommendations parameters to allow users to opt-in to potentially noisy recommendations about Azure Hybrid Benefit and Spot VMs
• Renamed recommendation query files from HubsRecommendations-* to Recommendations-Microsoft-* pattern and updated metadata to use PascalCase (ResourceGraph, Tenant) instead of lowercase
• Added a new "Recommendations" tab to the Azure portal deployment UI (createUiDefinition.json) with clear descriptions of included and optional recommendations
• Changed enableRecommendations default to false to reflect preview status
• Improved code organization by using conditional query file loading with the union() pattern

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/templates/finops-hub/main.bicep	Added three new parameters for recommendations control (enableRecommendations, enableAHBRecommendations, enableSpotRecommendations) and passed them to hub module
src/templates/finops-hub/modules/hub.bicep	Added recommendation parameters, changed enableRecommendations default to false, removed analytics dependency requirement from recommendations condition, and passed new parameters to recommendations module
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Recommendations/app.bicep	Implemented conditional query loading using union pattern, removed unused storage account resource, renamed dataset to dataset_resourceGraph (consistent casing), added case-insensitive switch logic
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Recommendations/queries/*.json	Renamed all 10 query files to follow Recommendations-Microsoft-* pattern, updated metadata to use PascalCase (ResourceGraph, Tenant), changed source from "Azure Resource Graph" to "FinOps hubs" (except AdvisorCost), updated type field to match new naming
src/templates/finops-hub/createUiDefinition.json	Added new recommendations tab with clear UI explaining included vs optional recommendations, permissions requirements, and parameter mappings

[helderpinto]

Why are we prefixing the type as being "Microsoft-*"? What ties these ARG queries to Microsoft? Is it the author? Should we add an "author" property instead?

[flanakin]

I prefixed anticipating a future where we have non-Microsoft recommendations as well. I wanted to differentiate from AWS and GCP recommendations when we get there or when customers ingest them themselves.