Skip to content

fix: Fix validate pr workflow#816

Merged
shirasassoon merged 42 commits intomicrosoft:mainfrom
shirasassoon:fix_validate_pr_workflow
Feb 16, 2026
Merged

fix: Fix validate pr workflow#816
shirasassoon merged 42 commits intomicrosoft:mainfrom
shirasassoon:fix_validate_pr_workflow

Conversation

@shirasassoon
Copy link
Copy Markdown
Contributor

Fixes #815

This pull request updates the PR validation workflow to enforce stricter requirements for version bump pull requests. Now, when a PR title matches a version format (e.g., vX.X.X), it must include not only constants.py and changelog.md, but also the corresponding version.md file.

Validation workflow changes:

  • Updated the version bump validation logic in .github/workflows/validate.yml to require that PRs titled with a version (vX.X.X) must include src/fabric_cicd/constants.py, docs/changelog.md, and the corresponding .changes/vX.X.X.md file in the changed files. If any of these files are missing, the workflow will fail with an explicit error message.

Shira Sassoon and others added 30 commits September 4, 2025 19:53
Copilot AI review requested due to automatic review settings February 15, 2026 13:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR validation workflow’s version-bump rules so PRs titled like vX.X.X must include the corresponding per-release .changes/vX.X.X.md file in addition to the version constant and changelog updates.

Changes:

  • Adjusted version-bump validation to require .changes/v<version>.md when PR title matches vX.X.X.
  • Added a missing-files collection to provide a clearer failure message when required files aren’t present.

Comment thread .github/workflows/validate.yml Outdated
Comment thread .github/workflows/validate.yml Outdated
Comment thread .github/workflows/validate.yml Outdated
@shirasassoon shirasassoon merged commit 0599898 into microsoft:main Feb 16, 2026
9 checks passed
@shirasassoon shirasassoon deleted the fix_validate_pr_workflow branch February 16, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Fix validate pr workflow

3 participants