Conversation
There was a problem hiding this comment.
Pull request overview
Adds a small demo workspace structure and a minimal deployment script under sample/, and extends the documentation with additional “Get help” links.
Changes:
- Add a demo
deploy.pyscript showing basicFabricWorkspace+publish_all_itemsusage. - Add sample Fabric item
.platformmetadata files for a Notebook and Lakehouse. - Add a “Get help” section to
docs/about.mdwith support/community links.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sample/fabric-cicd-demo/fabric-cicd-demo/fabric_items/deploy.py | New demo deployment script for publishing items from the sample directory. |
| sample/fabric-cicd-demo/fabric-cicd-demo/fabric_items/Notebook_1.Notebook/.platform | Adds sample Notebook platform metadata. |
| sample/fabric-cicd-demo/fabric-cicd-demo/fabric_items/Contoso_LH.Lakehouse/.platform | Adds sample Lakehouse platform metadata. |
| docs/about.md | Adds “Get help” section with links for issues/support/community. |
| **Found a bug or have a suggestion?** | ||
|
|
||
| - [Report an issue](https://github.com/microsoft/fabric-cicd/issues) | ||
| - [Request a feature](https://github.com/microsoft/fabric-cicd/discussions) |
There was a problem hiding this comment.
The Support section above directs users to file feature requests as GitHub Issues (with a template link), but this new "Request a feature" link points to Discussions. Please make the guidance consistent (either update the earlier text to recommend Discussions, or change this link to the feature-request issue template).
| - [Request a feature](https://github.com/microsoft/fabric-cicd/discussions) | |
| - [Request a feature](https://github.com/microsoft/fabric-cicd/issues/new?template=2-feature.yml) |
| **Need help using the CLI?** | ||
|
|
||
| - See [Troubleshooting](./troubleshooting.md) for common problems and solutions |
There was a problem hiding this comment.
This repository doesn’t appear to expose a CLI entrypoint (no project.scripts / console_scripts), so "Need help using the CLI?" is likely misleading here. Consider rewording this section to refer to using the library / deployment scripts instead, or link to the actual CLI docs if one exists elsewhere.
| **Need help using the CLI?** | |
| - See [Troubleshooting](./troubleshooting.md) for common problems and solutions | |
| **Need help using fabric-cicd?** | |
| - See [Troubleshooting](./troubleshooting.md) for common usage problems and solutions |
| ## Get help | ||
|
|
There was a problem hiding this comment.
PR metadata still contains the template text and the title/description are not linked to an issue as required by the repo contribution guidelines (title format like "Fixes #123 - ..."). Please update the PR title and description to reference the appropriate issue before merging.
| repo_dir = Path(__file__).resolve().parent # ...\fabric_items | ||
|
|
||
| workspace = FabricWorkspace( | ||
| workspace_id="<YOUR_WORKSPACE_ID>", |
There was a problem hiding this comment.
workspace_id example value ("<YOUR_WORKSPACE_ID>") is not a GUID, so this script will fail validation immediately if someone runs it before editing. Consider using a GUID-shaped placeholder (or workspace_name) so the example runs after only updating credentials/workspace details.
| workspace_id="<YOUR_WORKSPACE_ID>", | |
| workspace_id="00000000-0000-0000-0000-000000000000", |
1 participant
Description
Briefly describe what this PR does and why.
Linked Issue (REQUIRED)