-
Notifications
You must be signed in to change notification settings - Fork 19
feat(tools): add .shellcheckrc for ShellCheck configuration #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- add root-level .shellcheckrc with SC1091 global exclusion - configure MegaLinter BASH_SHELLCHECK_CONFIG_FILE 🔧 - Generated by Copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds centralized ShellCheck configuration for the edge-ai repository by introducing a .shellcheckrc file and integrating it with MegaLinter. The changes establish consistent shell script linting behavior across local development and CI pipelines, with a conservative initial configuration that disables SC1091 (unresolved source scripts) globally while setting bash as the default shell dialect. Follow-up work is tracked for enabling additional optional checks and removing redundant inline directives.
Changes:
- Added
.shellcheckrcconfiguration file withshell=bashand globaldisable=SC1091settings - Configured MegaLinter to use
.shellcheckrcviaBASH_SHELLCHECK_CONFIG_FILEsetting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.shellcheckrc |
New ShellCheck configuration file enforcing bash dialect and disabling SC1091 globally with comprehensive documentation |
.mega-linter.yml |
Added ShellCheck configuration file reference for MegaLinter integration |
🔧 - Generated by Copilot
🔒 - Generated by Copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
🔧 - Generated by Copilot
Pull Request
Description
Added root-level ShellCheck configuration file with global SC1091 exclusion (unresolved source scripts) and MegaLinter integration via
BASH_SHELLCHECK_CONFIG_FILEsetting. This provides consistent ShellCheck behavior across local development and CI pipelines..shellcheckrcat repository root with documented conventions.shellcheckrcviaBASH_SHELLCHECK_CONFIG_FILERelated Issue
Fixes #116
Type of Change
Implementation Details
Created
.shellcheckrcwith:shell=bash- enforces bash dialect checkingdisable=SC1091- global exclusion for unresolved source commandsUpdated
.mega-linter.ymlwith:BASH_SHELLCHECK_CONFIG_FILE: .shellcheckrcto ensure CI uses the same configTesting Performed
Validation Steps
shellcheck scripts/*.shand verify no SC1091 warningsChecklist
Additional Notes
Follow-up work tracked for:
require-variable-bracesoptional check (444 edits across 28 scripts)source-path=SCRIPTDIRdirective for common sourcing pattern🔧 - Generated by Copilot