Fix #2405: CalcManager build fail on Linux#2431
Open
dongfengweixiao wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix #2405: CalcManager build fail on Linux#2431dongfengweixiao wants to merge 1 commit intomicrosoft:mainfrom
dongfengweixiao wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Move Windows-specific headers (intsafe.h, winerror.h) into platform-specific conditional compilation blocks. On non-Windows platforms, use winerror_cross_platform.h instead, which provides Windows error codes and HRESULT macros. The intsafe.h functionality is already implemented in conv.cpp as custom Calc_ULong* functions, so it's not needed on non-Windows platforms. This change enables CalcManager to be compiled with non-MSVC toolchains such as GCC/Clang on Linux. Signed-off-by: Dee HY <dongfengweixiao@hotmail.com>
dongfengweixiao
force-pushed
the
fix/CalcManager_on_linux
branch
from
f3e3120 to
738f018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2405.
Move Windows-specific headers (intsafe.h, winerror.h) into platform-specific
conditional compilation blocks. On non-Windows platforms, use
winerror_cross_platform.h instead, which provides Windows error codes and
HRESULT macros.
The intsafe.h functionality is already implemented in conv.cpp as custom
Calc_ULong* functions, so it's not needed on non-Windows platforms.
This change enables CalcManager to be compiled with non-MSVC toolchains
such as GCC/Clang on Linux.